Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new S3 ranges to trusted local asg #881

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Adding new S3 ranges to trusted local asg #881

merged 2 commits into from
Sep 3, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Sep 3, 2024

Changes proposed in this pull request:

security considerations

Requires application owners to restart or restage their apps to pick up additional s3 ip cidr ranges

Comment on lines 198 to 203
rule {
protocol = "tcp"
description = "Allow access to AWS S3 Gateway"
destination = data.terraform_remote_state.iaas.outputs.s3_gateway_endpoint_cidr_3
ports = "443"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, once those changes are made, I think this can change to

  rule {
    protocol    = "tcp"
    description = "Allow access to AWS S3 Gateway"
    destination = data.terraform_remote_state.iaas.outputs.s3_gateway_endpoint_cidrs
    ports       = "443"
  }

@cweibel cweibel marked this pull request as draft September 3, 2024 15:02
@cweibel cweibel marked this pull request as ready for review September 3, 2024 15:21
@cweibel cweibel merged commit 65ea28d into main Sep 3, 2024
@cweibel cweibel deleted the s3asg branch September 3, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants