-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul #246
Merged
Merged
Overhaul #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move threshold to Dataclass - use context manager for open - use constants for warnings - whitespace tidying
markdboyd
reviewed
Jul 5, 2024
cweibel
reviewed
Dec 2, 2024
cweibel
previously approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long .gitignore aside, looks fine to test in staging
Created a new dataclass to unify user type data Changed var names to better reflect context Removed migration code Other misc
Bumps [certifi](https://github.com/certifi/python-certifi) from 2019.6.16 to 2023.7.22. - [Commits](certifi/python-certifi@2019.06.16...2023.07.22) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add codeowners * remove success-squad from codeowners
- update all the things - use a reasonable version of python
* chore: remove pipenv dependency - switch from pipenv to pip-tools - use hardened image instead of unmaintained upstream - add readme - add comment about using virtualenvironments - switch to general-task image
cweibel
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
security considerations
None