Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code for loading gem version dynamically #12

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

markdboyd
Copy link

@markdboyd markdboyd commented Dec 9, 2024

Changes proposed in this pull request:

  • update code for loading gem version dynamically to address runtime error. As is, the plugin is failing to start with NoMethodError: undefined method version' for nil:NilClass`
  • Remove Aws.eager_autoload! since it is deprecated in Ruby aws-sdk-core > 3

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just changing method for loading gem version dynamically

@markdboyd markdboyd requested a review from a team as a code owner December 9, 2024 22:00
Copy link

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@markdboyd markdboyd merged commit 0700cd6 into main Dec 9, 2024
2 of 3 checks passed
@markdboyd markdboyd deleted the fix-plugin branch December 9, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants