Update log group tag handling #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdboyd
commented
Dec 6, 2024
Comment on lines
+194
to
+207
| def should_fetch_tags(log_group_name) | ||
| # only fetch tags if | ||
| # - there is no timestamp for when the tags were last updated | ||
| # - OR the tags were last updated more than an hour ago (60 seconds * 60 minutes) | ||
| @tag_cache[log_group_name][:last_updated].nil? || | ||
| ((Time.now - @tag_cache[log_group_name][:last_updated]) > (60 * 60)) | ||
| end | ||
|
|
||
| def fetch_tags(log_group_name) | ||
| if @tag_cache.key?(log_group_name) | ||
| return @tag_cache[log_group_name][:tags] | ||
| else | ||
| tags = fetch_tags_from_cloudwatch(log_group_name) | ||
| @tag_cache[log_group_name] = { tags: tags} | ||
| return tags | ||
| end | ||
| return @tag_cache[log_group_name][:tags] if @tag_cache.key?(log_group_name) && !should_fetch_tags(log_group_name) | ||
|
|
||
| tags = fetch_tags_from_cloudwatch(log_group_name) | ||
| @tag_cache[log_group_name] = { tags: tags, last_updated: Time.now } | ||
| tags |
There was a problem hiding this comment.
These are the only meaningful changes in the PR. The rest are formatting changes suggested by Rubocop which I do think makes the code more readable and maintainable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Related to #8
Things to check
INFOand debugging statements are written withlog.debugor similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
None, just improving behavior of plugin so that tags are refreshed every hour