Skip to content

Commit

Permalink
Merge pull request #448 from cloud-gov/deprecate-node-16
Browse files Browse the repository at this point in the history
chore: don't build node 16
  • Loading branch information
drewbo authored Dec 6, 2023
2 parents 3f74209 + 78cc608 commit 8ad35c4
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/steps/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,13 @@ def runp(cmd):
NVMRC_PATH = CLONE_DIR_PATH / NVMRC
if NVMRC_PATH.is_file():
# nvm will output the node and npm versions used
# the warning is currently non-reachable but leaving it in for October 2024
# to warn about node 18 EOL
logger.info('Checking node version specified in .nvmrc')
runp("""
RAW_VERSION=$(nvm version-remote $(cat .nvmrc))
MAJOR_VERSION=$(echo $RAW_VERSION | cut -d. -f 1 | cut -dv -f 2)
if [[ "$MAJOR_VERSION" =~ ^(16|18|20)$ ]]; then
if [[ "$MAJOR_VERSION" =~ ^(18|20)$ ]]; then
echo "Switching to node version $RAW_VERSION specified in .nvmrc"
if [[ "$MAJOR_VERSION" -eq 16 ]]; then
Expand Down

0 comments on commit 8ad35c4

Please sign in to comment.