From 78cc608289253d338c0dd8cbf269214ac9ba7d25 Mon Sep 17 00:00:00 2001 From: Drew Bollinger Date: Tue, 5 Dec 2023 14:23:31 -0800 Subject: [PATCH] chore: don't build node 16 --- src/steps/build.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/steps/build.py b/src/steps/build.py index 249bfbb..ae60cd5 100644 --- a/src/steps/build.py +++ b/src/steps/build.py @@ -149,11 +149,13 @@ def runp(cmd): NVMRC_PATH = CLONE_DIR_PATH / NVMRC if NVMRC_PATH.is_file(): # nvm will output the node and npm versions used + # the warning is currently non-reachable but leaving it in for October 2024 + # to warn about node 18 EOL logger.info('Checking node version specified in .nvmrc') runp(""" RAW_VERSION=$(nvm version-remote $(cat .nvmrc)) MAJOR_VERSION=$(echo $RAW_VERSION | cut -d. -f 1 | cut -dv -f 2) - if [[ "$MAJOR_VERSION" =~ ^(16|18|20)$ ]]; then + if [[ "$MAJOR_VERSION" =~ ^(18|20)$ ]]; then echo "Switching to node version $RAW_VERSION specified in .nvmrc" if [[ "$MAJOR_VERSION" -eq 16 ]]; then