Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resource types to use hardened images #453

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Update resource types to use hardened images #453

merged 1 commit into from
Feb 15, 2024

Conversation

svenaas
Copy link
Contributor

@svenaas svenaas commented Feb 12, 2024 •
edited by apburnes
Loading

Closes cloud-gov/pages-core#4385

Changes proposed in this pull request:

  • Update pipelines to use our current hardened images
  • Updates python deps
  • Update build-container image to python 3.11
  • Removes unused codeclimate coverage

security considerations

Removes slack-notification-resource and replaces with hardened image
Updates Python deps

@svenaas svenaas requested a review from a team February 12, 2024 18:19
@apburnes apburnes force-pushed the update-resources branch 3 times, most recently from d3ad2a3 to 2497e0e Compare February 13, 2024 17:43
@apburnes apburnes requested a review from drewbo February 13, 2024 18:50
@apburnes apburnes force-pushed the update-resources branch 3 times, most recently from 9b8b961 to 1f9bfa9 Compare February 13, 2024 23:38
drewbo
drewbo approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@drewbo drewbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to Ubuntu 22 (Jammy/LTS) which defaults to python 3.10 and avoids a longer build step (we had previously stayed on Ubuntu 20 to support now deprecated versions of Ruby). The remainder of the PR looks good

@svenaas svenaas merged commit 8ed1ff1 into staging Feb 15, 2024
3 checks passed
@svenaas svenaas deleted the update-resources branch February 15, 2024 17:31
@apburnes apburnes mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbo drewbo drewbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace docker resource types with hardened images for pipelines (build-container)
2 participants
@svenaas @drewbo