chore: Add decrypt to build site params #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apburnes
force-pushed
the
chore-decrypt-params
branch
3 times, most recently
from
7a999fc to
4e83217
Compare
apburnes
force-pushed
the
chore-decrypt-params
branch
from
4e83217 to
7d7b17e
Compare
svenaas
reviewed
May 15, 2024
|
|
||
| space = vcap_application['space_name'] | ||
|
|
||
| encryption_ups = next( |
There was a problem hiding this comment.
Is there a realistic possibility that a matching service might not be found?
There was a problem hiding this comment.
Not really. We couple the service with the deployment and there would be a deploy error if the service didn't connect.
drewbo
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to cloud-gov/pages-core#4464
Changes proposed in this pull request:
security considerations
Adds decryption of params