Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Run build CalledProcessError exception #469

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix: Run build CalledProcessError exception #469

merged 2 commits into from
Jun 7, 2024

Conversation

apburnes
Copy link
Contributor

@apburnes apburnes commented Jun 6, 2024 •
edited
Loading

Closes #468

Changes proposed in this pull request:

  • Removes logging during a run_step raised exception
  • Moved run_step function into steps.build
  • Adds tests for run_step to verify pass and fail outcomes

security considerations

Bump requests to v2.32.2

@apburnes apburnes force-pushed the fix-called-process-error-exception branch from 8cc9c5d to ab19cfd Compare June 7, 2024 00:51
@apburnes apburnes requested a review from a team June 7, 2024 14:33
drewbo
drewbo previously approved these changes Jun 7, 2024
View reviewed changes
@apburnes apburnes requested a review from drewbo June 7, 2024 15:50
@apburnes apburnes merged commit d61fc69 into staging Jun 7, 2024
5 checks passed
@apburnes apburnes deleted the fix-called-process-error-exception branch June 7, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbo drewbo drewbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected exception raised during build 'CalledProcessError' object has no attribute 'replace'
2 participants
@apburnes @drewbo