Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fips endpoints #20

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Use fips endpoints #20

merged 4 commits into from
Sep 25, 2024

Conversation

spgreenberg
Copy link

Changes proposed in this pull request:

  • Updates to the lastest 1.x aws-sdk-go
  • Replaces deprecated session.New
  • Returns errors during session creation
  • Removes docker warnings

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Updates are good.

@spgreenberg spgreenberg merged commit b29c27f into main Sep 25, 2024
2 checks passed
@spgreenberg spgreenberg deleted the use-fips-endpoints branch September 25, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdboyd markdboyd markdboyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spgreenberg @markdboyd