81816 clouseau for clustered purge improvements #11
+35
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add 2 APIs(set_purge_seq, get_purge_seq). - keep purge_seq in clouseau. - adjust the commit logic to update purge seq. - update the test code. BugzID: 68280
- adjust the commit logic to update purge seq.
BugzID: 68280
- use pendingPurgeSeq in set_purge_seq and get_purge_seq. - update purgeSeq when pengdingPurgeSeq is committed. BugzId: 68280
- add a new api to get root dir. BugzId: 81816
| @@ -109,6 +109,8 @@ class IndexManagerService(ctx: ServiceContext[ConfigurationArgs]) extends Servic | |||
| case pid => | |||
| ('ok, pid) | |||
| } | |||
| case ('get_root_dir) => | |||
| ('ok, rootDir.getAbsolutePath()) | |||
There was a problem hiding this comment.
LGTM, it would be nice if you can provide a comment where this will be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The primary purpose of clustered purge is to clean databases that have multiple deleted tombstones or single documents that contain large numbers of conflicts. But it can also be used to purge any document (deleted or non-deleted) with any number of revisions.
With PR apache/couchdb#1187, the purge API and update on secondary index are implemented. The current PR is in charge of updating search index according to purge tree and record purge history in local purge document to make sure that the search index update is not out of date.
Testing recommendations
JIRA issue number
https://issues.apache.org/jira/browse/COUCHDB-3326
Related Issues or Pull Requests
apache/couchdb#1186
apache/couchdb#1187
Checklist