Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:remove deprecations #30

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

fix:remove deprecations #30

wants to merge 27 commits into from

Conversation

vjdbj
Copy link
Member

@vjdbj vjdbj commented Sep 13, 2024

what

  • Added subscription_id for provider in root module
  • Also updated the modules release version in root modules
  • Fixed automerge workflow.

why

  • subscription_id is compulsory to add for terraform planning

13archit
13archit reviewed Sep 16, 2024
View reviewed changes
README.yaml Outdated Show resolved Hide resolved
13archit
13archit reviewed Sep 16, 2024
View reviewed changes
README.yaml Outdated Show resolved Hide resolved
13archit
13archit reviewed Sep 16, 2024
View reviewed changes
README.yaml Outdated Show resolved Hide resolved
13archit
13archit reviewed Sep 16, 2024
View reviewed changes
versions.tf Outdated Show resolved Hide resolved
13archit
13archit reviewed Oct 4, 2024
View reviewed changes
output.tf Outdated
@@ -1,18 +1,19 @@
output "vpn_gw_id" {
value = join("", azurerm_virtual_network_gateway.vpngw.*.id)
value = length(azurerm_virtual_network_gateway.vpngw) > 0 ? azurerm_virtual_network_gateway.vpngw[0].id : null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we are using the length function? Also it is not used correctly in all output.

13archit
13archit reviewed Oct 4, 2024
View reviewed changes
variables.tf
@@ -4,13 +4,6 @@ variable "resource_group_name" {
description = "A container that holds related resources for an Azure solution"
}

variable "location" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its is not being used.

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output 



      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    














        

  
        





        

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    











      

  
    

      
        1 similar comment
      
    

  
    

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    














        

  
        





        

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
        





        

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
        





        

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
        





        

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
        





        

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
        





        

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    














  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    

    
  

    Reviewers
  


    


        

          

  
    @13archit
  
    13archit



          
            
              
            
          
          13archit left review comments

        


      






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




        
      

    

  
      

  

    

      3 participants
    

    

        
          @vjdbj 
        
          @clouddrove-ci 
        
          @13archit