[security] Unsafe Inline Script #3876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabraiz12
requested review from
JohanAhlen,
Harshg999,
bjornalm and
sreenaths
tabraiz12
force-pushed
the
unsafe-inline
branch
from
257f4f3
to
5b5dd88
Compare
tabraiz12
force-pushed
the
unsafe-inline
branch
from
5b5dd88
to
4c3815b
Compare
Harshg999
reviewed
Nov 3, 2024
| @@ -137,6 +137,9 @@ http_500_debug_mode=false | |||
| # X-Content-Type-Options: nosniff This is a HTTP response header feature that helps prevent attacks based on MIME-type confusion. | |||
| ## secure_content_security_policy="script-src 'self' 'unsafe-inline' 'unsafe-eval' *.googletagmanager.com *.doubleclick.net data:;img-src 'self' *.doubleclick.net http://*.tile.osm.org *.tile.osm.org *.gstatic.com data:;style-src 'self' 'unsafe-inline' fonts.googleapis.com;connect-src 'self' *.google-analytics.com;frame-src *;child-src 'self' data: *.vimeo.com;object-src 'none'" | |||
|
|
|||
| # Enable nonce attribute to remove unsafe-inline and auto remove unsafe-inline from csp | |||
| ## csp_nonce=True | |||
| @@ -142,6 +142,10 @@ | |||
| # X-Content-Type-Options: nosniff This is a HTTP response header feature that helps prevent attacks based on MIME-type confusion. | |||
| ## secure_content_security_policy="script-src 'self' 'unsafe-inline' 'unsafe-eval' *.googletagmanager.com *.doubleclick.net data:;img-src 'self' *.doubleclick.net http://*.tile.osm.org *.tile.osm.org *.gstatic.com data:;style-src 'self' 'unsafe-inline' fonts.googleapis.com;connect-src 'self' *.google-analytics.com;frame-src *;child-src 'self' data: *.vimeo.com;object-src 'none'" | |||
|
|
|||
| # Enable nonce attribute to remove unsafe-inline and auto remove unsafe-inline from csp | |||
| ## csp_nonce=True | |||
Comment on lines
+524
to
+525
| # Assuming 'csp_nonce' is set in the request and CSP_NONCE controls its usage | ||
| if desktop.conf.CSP_NONCE.get(): |
There was a problem hiding this comment.
Instead of assuming, why not check for it by using hasattr()?
Comment on lines
+527
to
+529
| if csp_nonce: | ||
| return f' nonce={csp_nonce}' | ||
| return '' |
There was a problem hiding this comment.
Nit: Try something like this once?
return f' nonce={csp_nonce}' if csp_nonce else ''
Comment on lines
+875
to
+876
| nonce = secrets.token_urlsafe() | ||
| request.csp_nonce = nonce |
bjornalm
approved these changes
Nov 4, 2024
| 'text script': function (text) { | ||
| return text; | ||
| } | ||
| 'text script': text => text |
There was a problem hiding this comment.
Just out of curiosity, was this change needed or just an improvement?
JohanAhlen
reviewed
Nov 4, 2024
| @@ -295,8 +296,9 @@ ${ hueIcons.symbols() } | |||
| </div> | |||
| ${ commonshare() | n,unicode } | |||
|
|
|||
| % for bundle in get_hue_bundles('hue'): | |||
| ${ render_bundle(bundle) | n,unicode } | |||
| % for bundle in get_hue_bundles('login' if section == 'login' else 'hue', 'LOGIN' if section == 'login' else 'DEFAULT'): | |||
There was a problem hiding this comment.
Why the login related checks for hue.mako?
| <script type="application/json" id="editorOptionsJson"> | ||
| ${ options_json | n,unicode,antixss } | ||
| </script> | ||
| <script ${nonce_attribute(request)} src="${ static('desktop/js/editor-component.js') }"></script> |
There was a problem hiding this comment.
Missing js file in the commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have Closed the existing PR, splitting the PR to smaller PR for easier Review:
Upcoming PRs:
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.