refactor!: make functions infallible where possible #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looked into this a bit more and discovered that there is a clippy lint for this: https://rust-lang.github.io/rust-clippy/master/#/unnecessary_wraps I ran it and found another instance of the same issue. |
thomaseizinger
changed the title
Tunn::new infallible
thomaseizinger
force-pushed
the
refactor/infallible-ctor
branch
from
69e3ff0
to
7ac5273
Compare
|
@Noah-Kennedy Anything else I can do to assist in merging this? :) |
|
No, this looks good |
Noah-Kennedy
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While inspecting the code in search for when constructing a new
Tunnmight fail I noticed that it can actually never fail.