Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: simplify publish-production check summary #19031

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

hamirmahal
Copy link
Contributor

@hamirmahal hamirmahal commented Jan 6, 2025

Fixes #19030

Summary

This change simplifies the .github/workflows/publish-production.yml / Publish Production (push) summary that appears when looking at the checks for a particular commit.

Screenshots (optional)

Without this change

image

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these changes, the check summary simplifies to

image

@KianNH KianNH requested a review from kodster28 as a code owner January 21, 2025 17:13
@KianNH
Copy link
Contributor

KianNH commented Jan 21, 2025

Thanks for spotting this!

@KianNH KianNH enabled auto-merge (squash) January 21, 2025 17:29
@KianNH KianNH merged commit 44a499b into cloudflare:production Jan 21, 2025
5 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Jan 21, 2025
Copy link

holopin-bot bot commented Jan 21, 2025

Congratulations @hamirmahal, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm66str2s97830cl48855wtku

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@hamirmahal
Copy link
Contributor Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes a docs contribution, big or small size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluttered publish-production check summary
10 participants