Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs Site] Fix leading spaces in anchors #19331

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[Docs Site] Fix leading spaces in anchors #19331

merged 1 commit into from
Jan 21, 2025

Conversation

KianNH
Copy link
Contributor

@KianNH KianNH commented Jan 21, 2025

Summary

Closes #16199

Resolves trailing spaces left behind after components are added (# Foo <Component /> being slugged as foo-) and if a link is contained (## **400 Bad Request ([RFC7231](https://tools.ietf.org/html/rfc7231))** being slugged as 400-bad-request-rfc7231-).

This was due to leading spaces both when using components, or added when we insert for external links.

All other headings are not affected, as "foo".replaceAll(" ↗", "").trimEnd(); will still be "foo".

Copy link

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1ef838c
Status: ✅  Deploy successful!
Preview URL: https://b743c15e.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://kian-pcx-13050.cloudflare-docs-7ou.pages.dev

View logs

@KianNH KianNH merged commit 31f1cba into production Jan 21, 2025
13 checks passed
@KianNH KianNH deleted the kian/PCX-13050 branch January 21, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:analytics Related to Analytics product product:cache Issues or PRs related to Cache product:cloudflare-one size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link for header with inline badge