Merge pull request #1489 from daku10/patch-build-caching-on-page

Add support for build_caching of Pages Project
cloudflare · Jan 31, 2024 · d32f339 · d32f339
2 parents 812ef3a + d160952
commit d32f339
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/.changelog/1489.txt b/.changelog/1489.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+pages_project: Add `build_caching` attribute
+```
diff --git a/pages_project.go b/pages_project.go
@@ -53,6 +53,7 @@ type PagesProjectSourceConfig struct {
 
 // PagesProjectBuildConfig represents the configuration of a Pages project build process.
 type PagesProjectBuildConfig struct {
+	BuildCaching      *bool  `json:"build_caching,omitempty"`
 	BuildCommand      string `json:"build_command"`
 	DestinationDir    string `json:"destination_dir"`
 	RootDir           string `json:"root_dir"`

diff --git a/pages_project_test.go b/pages_project_test.go
@@ -44,6 +44,7 @@ const (
           }
         },
         "build_config": {
+          "build_caching": true,
           "build_command": "npm run build",
           "destination_dir": "build",
           "root_dir": "/",
@@ -178,6 +179,7 @@ const (
             }
           ],
           "build_config": {
+            "build_caching": true,
             "build_command": "npm run build",
             "destination_dir": "build",
             "root_dir": "/",
@@ -269,6 +271,7 @@ const (
             }
           ],
           "build_config": {
+            "build_caching": true,
             "build_command": "npm run build",
             "destination_dir": "build",
             "root_dir": "/",
@@ -399,6 +402,7 @@ var (
 	}
 
 	expectedPagesProjectBuildConfig = &PagesProjectBuildConfig{
+		BuildCaching:      BoolPtr(true),
 		BuildCommand:      "npm run build",
 		DestinationDir:    "build",
 		RootDir:           "/",