Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds stream create video param to tus initiate #1386

Merged
merged 6 commits into from
Jan 29, 2024
Merged

adds stream create video param to tus initiate #1386

merged 6 commits into from
Jan 29, 2024

Conversation

bbbshah
Copy link
Contributor

@bbbshah bbbshah commented Sep 2, 2023

Description

stream.StreamInitiateTUSVideoUpload currently allows you create a video stream
for upload using TUS protocol. Due to lack of maxDurationSeconds, the streams
created (for direct_user=true) results in maxDurationSeconds= 14400 which
takes the video billing quota until the video is uploaded. This PR adds supports to
pass additional params MaxDurationSeconds and Expiry in TUSUploadMetadata
to add appropriate functionality to the newly created stream/video.

Has your change been tested?

Added unit test to verify expiry and maxDurationSeconds metadata values are
properly encoded. Manually tested these by making API calls to cloudflare api using
a test account and verifying these values are correctly set in newly created stream video.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

changelog detected ✅

@bbbshah bbbshah marked this pull request as ready for review October 3, 2023 22:06
@bbbshah bbbshah requested a review from jacobbednarz as a code owner October 3, 2023 22:06
@jacobbednarz
Copy link
Member

support for this has landed in the public API, thanks for the PR!

@jacobbednarz jacobbednarz merged commit 5ce221e into cloudflare:master Jan 29, 2024
3 checks passed
@github-actions github-actions bot added this to the v0.87.0 milestone Jan 29, 2024
github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
Copy link
Contributor

This functionality has been released in v0.87.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
@bbbshah bbbshah deleted the support-stream-create-params-for-tus branch January 31, 2024 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants