Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add resolve action to allowed gateway rules #1615

Merged

Conversation

joebb97
Copy link
Contributor

@joebb97 joebb97 commented Mar 26, 2024

Description

Resolver policies require the policy action to be "resolve", which was not allowed before this change.

Has your change been tested?

Tested through use in the terraform provider locally

Types of changes

What sort of change does your code introduce/modify?

  • [*] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [* ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@joebb97 joebb97 requested a review from jacobbednarz as a code owner March 26, 2024 17:13
Copy link
Contributor

github-actions bot commented Mar 26, 2024

changelog detected ✅

@joebb97
Copy link
Contributor Author

joebb97 commented Mar 26, 2024

I don't understand the changelog bot, there is very clearly a changelog included in this pr

@joebb97 joebb97 force-pushed the jbuiteweg/fix-resolver-policies-action branch from c4f1b2f to a8bf244 Compare March 26, 2024 17:44
@joebb97
Copy link
Contributor Author

joebb97 commented Mar 26, 2024

Didn't realize the changelog number had to match the PR number. Good to know

@jacobbednarz jacobbednarz merged commit 9ff8452 into cloudflare:master Mar 27, 2024
10 checks passed
@github-actions github-actions bot added this to the v0.92.0 milestone Mar 27, 2024
Copy link
Contributor

This functionality has been released in v0.92.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants