Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GATE-5639: update teams account via PATCH and add custom certificate setting #1811

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

alyssamw
Copy link
Contributor

@alyssamw alyssamw commented Apr 16, 2024

Description

Adds a fix for BUGS-726 in which the custom certificate setting was being overwritten. This adds the existing custom certificate setting to Teams account configuration.

Documentation in https://developers.cloudflare.com/api/operations/zero-trust-accounts-update-zero-trust-account-configuration

Has your change been tested?

Tests in a/teams_accounts_test.go.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@alyssamw alyssamw requested a review from jacobbednarz as a code owner April 16, 2024 22:36
Copy link
Contributor

changelog detected ✅

@alyssamw alyssamw force-pushed the alyssaw/gate-5639 branch 3 times, most recently from 933bc8d to 0a72b40 Compare April 17, 2024 15:29
@alyssamw
Copy link
Contributor Author

alyssamw commented Apr 17, 2024

Removed change to PATCH to follow terraform convention for PUT

@alyssamw alyssamw force-pushed the alyssaw/gate-5639 branch from 0a72b40 to 3dec75d Compare April 17, 2024 15:36
@jacobbednarz jacobbednarz merged commit 6afd3ff into cloudflare:master Apr 18, 2024
10 checks passed
@github-actions github-actions bot added this to the v0.94.0 milestone Apr 18, 2024
Copy link
Contributor

This functionality has been released in v0.94.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants