Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-6145 support multi-valued + service token auth for scim provisioning #3708

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

khiller-cf
Copy link
Contributor

Description

Support Access Service Tokens as an authentication method for SCIM provisioning to Access Applications. Additionally, support configuring multiple authentication methods for SCIM provisioning to Access applications. This is useful when you have an application behind Access, but the SCIM provider also has its own authentication method.

Has your change been tested?

Unit tests

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

changelog detected ✅

@@ -110,13 +110,42 @@ const (
AccessApplicationScimAuthenticationSchemeHttpBasic AccessApplicationScimAuthenticationScheme = "httpbasic"
AccessApplicationScimAuthenticationSchemeOauthBearerToken AccessApplicationScimAuthenticationScheme = "oauthbearertoken"
AccessApplicationScimAuthenticationSchemeOauth2 AccessApplicationScimAuthenticationScheme = "oauth2"
ScimAuthenticationAccessServiceToken AccessApplicationScimAuthenticationScheme = "access_service_token"
Copy link
Member

@jacobbednarz jacobbednarz Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as this is exporting a global constant, we'll want to namespace it.

Suggested change
ScimAuthenticationAccessServiceToken AccessApplicationScimAuthenticationScheme = "access_service_token"
AccessApplicationScimAuthenticationAccessServiceToken AccessApplicationScimAuthenticationScheme = "access_service_token"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll want to update the rest of the usage of this as well to make sure it all still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants