Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows valid values in a code block #6

Merged
merged 2 commits into from
Apr 19, 2017
Merged

Conversation

Relequestual
Copy link
Contributor

Also adds quotes for strings, and shows "null" for a null enum value.

Fixes cloudflare/doca#35

@tajo
Copy link
Contributor

tajo commented Feb 22, 2017

> doca-bootstrap-theme@0.2.0 lint /Users/miksu/Projects/doca-bootstrap-theme
> eslint components || true


/Users/miksu/Projects/doca-bootstrap-theme/components/constraints.js
   3:7   error  'ImmutablePropTypes' is assigned a value but never used  no-unused-vars
  12:3   error  render should be placed after considerType               react/sort-comp
  38:68  error  There should be no spaces inside this paren              space-in-parens
  40:13  error  Expected line break before `.reduce`                     newline-per-chained-call
  40:19  error  There should be no spaces inside this paren              space-in-parens
  40:56  error  There should be no spaces inside this paren              space-in-parens
  40:58  error  There should be no space before '}'                      react/jsx-curly-spacing
  52:15  error  Unexpected space before function parentheses             space-before-function-paren
  52:24  error  Block must not be padded by blank lines                  padded-blocks
  54:5   error  Expected space(s) after "if"                             keyword-spacing
  54:26  error  Missing space before opening brace                       space-before-blocks
  55:14  error  Strings must use singlequote                             quotes
  55:14  error  Unexpected string concatenation                          prefer-template
  55:29  error  Strings must use singlequote                             quotes
  57:5   error  Expected space(s) after "if"                             keyword-spacing
  57:24  error  Missing space before opening brace                       space-before-blocks
  58:14  error  Strings must use singlequote                             quotes

✖ 17 problems (17 errors, 0 warnings)

~/Projects/doca-bootstrap-theme: Relequestual-master 

@Relequestual
Copy link
Contributor Author

I'll get right on it. I don't know why I don't see these in my editor =/

@Relequestual
Copy link
Contributor Author

I'm having a problems running npm install for this module from scratch.
Dev dependancies lists "eslint": "^3.0.1",, however...
eslint@^2.9.0, required by eslint-config-airbnb@9.0.1

According to semver...

^1.2.3 := >=1.2.3 <2.0.0

So by depending on eslint ^3 and the aribnb config, which requires eslint ^2, this creates a dependancy problem.

When I do npm install && npm list | grep eslint, I get the following:

├─┬ babel-eslint@6.1.2
├─┬ UNMET PEER DEPENDENCY eslint@3.16.1
├─┬ eslint-config-airbnb@9.0.1
│ ├── UNMET PEER DEPENDENCY eslint@^2.9.0
│ └── eslint-config-airbnb-base@3.0.1
├─┬ eslint-loader@1.6.3
├─┬ eslint-plugin-import@1.16.0
│ ├─┬ eslint-import-resolver-node@0.2.3
├─┬ eslint-plugin-jsx-a11y@1.5.5
├── eslint-plugin-react@5.2.2
npm ERR! peer dep missing: eslint@^2.9.0, required by eslint-config-airbnb@9.0.1
npm ERR! peer dep missing: eslint@^2.9.0, required by eslint-config-airbnb-base@3.0.1

As such, I seem to be unable to run the linter =/
Any suggestions? Am I doing something wrong here?
Thanks.

@Relequestual
Copy link
Contributor Author

Managed to work around this by removing the eslint dependancy from the root level, and letting it be installed as a dependancy of the airbnb config.

@tajo tajo merged commit b2547db into cloudflare:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants