Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid values with commas make the values unclear #35

Closed
Relequestual opened this issue Feb 1, 2017 · 4 comments
Closed

Valid values with commas make the values unclear #35

Relequestual opened this issue Feb 1, 2017 · 4 comments

Comments

@Relequestual
Copy link

In the instance where valid values have commas, it becoms unclear if a comma is a breaking character or part of the value.
Example:

screen shot 2017-02-01 at 11 51 32

I don't know if quotes or some sort of highlighting would be better.

@Relequestual Relequestual changed the title Valid values needs to make value seperation clearer Valid values with commas make the values unclear Feb 1, 2017
@handrews
Copy link
Contributor

handrews commented Feb 1, 2017

We should fix this along with #14 (switching from "example" to "examples" for Draft 06)

@Relequestual
Copy link
Author

Actually... regarding #14 I err would say it depends.

I still want to use the JSON Schema documents I generate to give to devs alongside the resulting HTML documentation. I don't want to give them draft-6 versions when there's no tooling for it.

I realise examples probably wouldn't interact with tooling much.
Could doca still support draft-4 while also supporting draft-6?

@Relequestual
Copy link
Author

Incoming PR for this one... =]

@Relequestual
Copy link
Author

I also discovered that a null value comes out as empty string... fixing that also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants