Skip to content

Commit

Permalink
remove husky/pre-commit hooks
Browse files Browse the repository at this point in the history
We now run checks in CI, so let's keep commits fast locally. This patch removes husky and the precommit hook. We also add a prettier check so unformatted text will fail in CI.
  • Loading branch information
threepointone committed Jul 3, 2024
1 parent 51ce1ce commit 3b38d5e
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 37 deletions.
10 changes: 0 additions & 10 deletions .husky/pre-commit

This file was deleted.

1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
public/mockServiceWorker.js
22 changes: 0 additions & 22 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,17 @@
"sideEffects": false,
"scripts": {
"build": "remix build",
"lint": "eslint --ignore-path .gitignore --cache --cache-location ./node_modules/.cache/eslint .",
"lint": "prettier --check . && eslint --ignore-path .gitignore --cache --cache-location ./node_modules/.cache/eslint .",
"dev": "remix dev --manual -c \"npm start\"",
"start": "wrangler dev ./build/index.js",
"prebuild": "npm run clean",
"clean": "del public/build && del build",
"ci-test": "CI=true run-p typecheck test",
"remove-sourcemaps": "del public/build/**/*.map",
"deploy": "npm run ci-test && npm run build -- --sourcemap && npm run remove-sourcemaps && wrangler publish --define __RELEASE__:\\\"$(git rev-parse --short HEAD)\\\" --define __SENTRY_DSN__:\\\"$SENTRY_DSN\\\"",
"prettier": "prettier -w --ignore-path .gitignore .",
"prettier": "prettier -w .",
"typecheck": "tsc --noEmit --skipLibCheck",
"typecheck:watch": "npm run typecheck -- --watch",
"prepare": "husky install",
"test": "vitest",
"test:ci": "vitest --watch false",
"check": "npm run lint && npm run typecheck && npm run test:ci"
Expand Down Expand Up @@ -62,7 +61,6 @@
"del-cli": "^5.1.0",
"eslint": "^8.56.0",
"git-format-staged": "^3.1.1",
"husky": "^9.0.11",
"msw": "^2.3.1",
"npm-run-all": "^4.1.5",
"prettier": "^3.3.2",
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"include": ["remix.env.d.ts", "**/*.ts", "**/*.tsx"],
"include": ["remix.env.d.ts", "**/*.ts", "**/*.tsx", "vitest.config.mts"],
"compilerOptions": {
"lib": ["DOM", "DOM.Iterable", "ES2019"],
"types": ["@cloudflare/workers-types"],
Expand Down
File renamed without changes.

0 comments on commit 3b38d5e

Please sign in to comment.