Use RxJSPeer for the peer connection pushing/pulling #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dead track detection Use RxJS for screensharing Organize hooks a bit better Fix bug in device selection menu Update packet loss info
renandincer
approved these changes
Jul 19, 2024
third774
force-pushed
the
rxjs-for-rtcpeerconnection
branch
from
9c90b3f
to
2b6f5ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the giant PR, but this was a LOT to refactor 😅
This completely replaces the previous Peer class which was promise based with a Peer class based on RxJS. This approach buys us a lot of reliability inside the non-React boundaries of our logic.
Track acquisition/retention (which has already merged) means that we can fall back to other devices gracefully, and now the pushed/pulled tracks can automatically reconnect if the peer connection is disrupted while React happily just updates things when new tracks/track metadata is emitted.