Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable_for_time is an undocumented required key of the cloudflare_teams_account's proxy attribute #4014

Closed
3 tasks done
steveAG opened this issue Sep 16, 2024 · 3 comments
Closed
3 tasks done
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@steveAG
Copy link

steveAG commented Sep 16, 2024

Confirmation

  • This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
  • I have searched the issue tracker and my issue isn't already found.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

Terraform 1.6.0 with the provider 4.41.0

Affected resource(s)

  • cloudflare_teams_account

Terraform configuration files

resource "cloudflare_account" "account" {
  name              = local.account_name
  type              = local.account_type
  enforce_twofactor = true
}

resource "cloudflare_teams_account" "teams" {
  account_id           = cloudflare_account.account.id
  activity_log_enabled = true
  tls_decrypt_enabled  = false

  block_page {
    enabled          = local.page_block_enabled
    background_color = "#ffffff"
    logo_path        = local.company_logo
    header_text      = "Website Blocked"
    footer_text      = "Cloudflare Zero Trust blocked access to this website."
    name             = local.org_name
    mailto_address   = local.page_block_contact
    mailto_subject   = "Cloudflare Zero Trust Block"
  }

  body_scanning {
    inspection_mode = "shallow"
  }

  antivirus {
    enabled_download_phase = true
    enabled_upload_phase   = true
    fail_closed            = false
  }

  fips {
    tls = true
  }

  proxy {
    tcp        = true
    udp        = true
    root_ca    = true
    virtual_ip = false
  }

  url_browser_isolation_enabled = false

  logging {
    redact_pii = false
    settings_by_rule_type {
      dns {
        log_all    = "all"
        log_blocks = "blocked"
      }
      http {
        log_all    = "all"
        log_blocks = "blocked"
      }
      l4 {
        log_all    = "all"
        log_blocks = "blocked"
      }
    }
  }
}

Link to debug output

N/A, just a doc update so I didn't collect debug logs

Panic output

No response

Expected output

Applied successfully with previous versions of the provider, the new required attribute is fine and appears valid, but it is absent from the provider documentation, so it took some digging to determine that the new required attribute needs to be provided as a part of the value for proxy

Actual output

Error: Missing required argument
│ 
│   on teams.tf line 31, in resource "cloudflare_teams_account" "teams":
│   31:   proxy {
│ 
│ The argument "disable_for_time" is required, but no definition was found.

Steps to reproduce

  1. Attempt to apply without defining the new attribute for proxy
  2. Review provider documentation for details about the new attribute, and find that it is undocumented.

Additional factoids

Commit that added the new attribute: 4446121

References

No response

@steveAG steveAG added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 16, 2024
Copy link
Contributor

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

Copy link
Contributor

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 16, 2024
@steveAG
Copy link
Author

steveAG commented Sep 16, 2024

Closing in favor of a PR, missed the doc update issue type callout.

@steveAG steveAG closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

1 participant