Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grit pattern for "zero_trust" namespace migration has typos #4842

Closed
3 tasks done
lwimmer opened this issue Jan 7, 2025 · 4 comments · Fixed by #4844
Closed
3 tasks done

Grit pattern for "zero_trust" namespace migration has typos #4842

lwimmer opened this issue Jan 7, 2025 · 4 comments · Fixed by #4844
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Milestone

Comments

@lwimmer
Copy link

lwimmer commented Jan 7, 2025

Confirmation

  • This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
  • I have searched the issue tracker and my issue isn't already found.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

This affects the Grit Pattern and has nothing to do with Terraform directly.

Affected resource(s)

https://github.com/cloudflare/terraform-provider-cloudflare/blob/3a3c3dee56dfaa79273579f6715670ebad36c06a/.grit/patterns/cloudflare_terraform_v4_40_0_zero_trust_namespace_renames_configuration.grit

Terraform configuration files

Again, this is not related to Terraform (see above)

Link to debug output

Not related to Terraform

Panic output

No response

Expected output

Grit rules should be correct

Actual output

Grit rules have typos e.g. "clouflare" instead of "cloudflare" (-> missing the letter d)

Steps to reproduce

Try to run the grit rules:
https://github.com/cloudflare/terraform-provider-cloudflare/blob/3a3c3dee56dfaa79273579f6715670ebad36c06a/.grit/patterns/cloudflare_terraform_v4_40_0_zero_trust_namespace_renames_configuration.grit

This creates non-existing resources like "clouflare_zero_trust_access_application". It should be "cloudflare" not "clouflare" (missing d)

Additional factoids

No response

References

No response

@lwimmer lwimmer added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 7, 2025
@lwimmer
Copy link
Author

lwimmer commented Jan 7, 2025

This is not related to Terraform, so Terraform debug output does not make any sense here!

Copy link
Contributor

github-actions bot commented Jan 8, 2025

This functionality has been released in v4.50.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant