Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FowardingAndOthers test #4744

Merged

Conversation

jafowler
Copy link
Contributor

@jafowler jafowler commented Dec 10, 2024

This aims to fix the FowardingAndOthers Acceptance test.

=== RUN   TestAccCloudflarePageRule_ForwardingAndOthers
--- PASS: TestAccCloudflarePageRule_ForwardingAndOthers (1.46s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/services/page_rule 4.233s

Terraform does some weird things with the API output, but essentially it makes it a multi line object with various unnecessary whitespace causing issues with regexp.

  error=
  | exit status 1
  |
  | Error: failed to make http request
  |
  |   with cloudflare_page_rule.nkcfpuwhfo,
  |   on terraform_plugin_test.tf line 12, in resource "cloudflare_page_rule" "nkcfpuwhfo":
  |   12: resource "cloudflare_page_rule" "nkcfpuwhfo" {
  |
  | POST
  | "https://api.cloudflare.com/client/v4/zones/0da42c8d2132a9ddaf714f9e7c920711/pagerules":
  | 400 Bad Request {"success":false,"errors":[{"code":1004,"message":"Page Rule
  | validation failed: See messages for
  | details."}],"messages":[{"code":1,"message":".settings: \"forwarding_url\"
  | may not be used with \"any setting\"","type":null}],"result":null}

Copy link
Contributor

@mgirouard mgirouard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacobbednarz jacobbednarz merged commit e7462b2 into cloudflare:next Dec 10, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants