Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache_key_fields to page_rules #4759

Merged

Conversation

jafowler
Copy link
Contributor

This PR aims to add Cache Key Fields to page rules:

➜ TF_ACC=1 go test ./internal/services/page_rule/ -run "^TestAccCloudflarePageRule_CacheKeyFields" -v -count=1
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsBasic
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsBasic (5.60s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsIgnoreQueryStringOrdering
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsIgnoreQueryStringOrdering (4.21s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsExcludeAllQueryString
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsExcludeAllQueryString (4.24s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsExcludeMultipleValuesQueryString
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsExcludeMultipleValuesQueryString (3.99s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsNoQueryStringValuesDefined
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsNoQueryStringValuesDefined (4.29s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsIncludeAllQueryStringValues
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsIncludeAllQueryStringValues (4.34s)
=== RUN   TestAccCloudflarePageRule_CacheKeyFieldsIncludeMultipleValuesQueryString
--- PASS: TestAccCloudflarePageRule_CacheKeyFieldsIncludeMultipleValuesQueryString (3.77s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/services/page_rule 35.392s

Some tests have been modified / commented out. I have an open thread with the Cache team about the approach. I'll take responsibility for any updates necessary.

@jafowler jafowler force-pushed the jfowler/next-page-rule-cache-key-fields branch from eb2fc11 to b46ba2d Compare December 12, 2024 21:30
Copy link
Contributor

@mgirouard mgirouard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacobbednarz jacobbednarz merged commit 2299f58 into cloudflare:next Dec 12, 2024
0 of 2 checks passed
@jafowler jafowler deleted the jfowler/next-page-rule-cache-key-fields branch December 12, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants