Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cache ttl by status to page rules #4771

Merged
merged 2 commits into from
Dec 13, 2024
Merged

add cache ttl by status to page rules #4771

merged 2 commits into from
Dec 13, 2024

Conversation

jafowler
Copy link
Contributor

This PR aims to add support for the cache ttl by status page rule.

=== RUN   TestAccCloudflarePageRule_CacheTTLByStatus
--- PASS: TestAccCloudflarePageRule_CacheTTLByStatus (3.77s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/services/page_rule 6.688s

@jafowler jafowler requested a review from mgirouard December 13, 2024 19:29
@vaishakdinesh
Copy link
Member

lgtm

@mgirouard mgirouard merged commit f011eed into cloudflare:next Dec 13, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musa-cf musa-cf musa-cf approved these changes

@mgirouard mgirouard mgirouard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jafowler @vaishakdinesh @mgirouard @musa-cf