-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acceptance test generator #4819
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
requested changes
Jan 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at a high level, i'm 👍 . two things we should do though to make the UX more consistent here are:
- we move this into
tools/
given we aren't expecting the consumer of the library to use this. it's internal only and should be stripped from the end package that terraform consumes. check out the currentmaster
version of this for some inspiration. - this should be wrapped in a
scripts/...
execution. the goal of thescripts
directory is to have a unified interface with how we expose tooling to operators. a deeper read on this is at https://github.com/github/scripts-to-rule-them-all but in essence, it means we maintain this pattern for all of the repositories.
Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
pre-built executable for it
@jacobbednarz Thanks for the feedback! I've pushed a new commit with your suggestions. |
jacobbednarz
reviewed
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
go.work
files to gitignore listTool usage examples
Happy path example:
With
-dryrun
flag:Error case: