Re-enable volume service test #1257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove pushing of cfpersi/nfs-cats test server, use cf-deployment ops file instead: https://github.com/cloudfoundry/cf-deployment/blob/main/operations/test/enable-nfs-test-server.yml * add "volume_service_bind_config" parameter with default values from https://github.com/cloudfoundry/cf-volume-services-acceptance-tests/blob/main/persi_acceptance_suite_test.go#L82 * a working value for "volume_service_create_config" can be found here: https://github.com/cloudfoundry/cf-volume-services-acceptance-tests/blob/main/persi_acceptance_suite_test.go#L76
|
CATs config json would need these parameters: |
10 tasks
ctlong
previously approved these changes
Sep 26, 2024
davewalter
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Fix the volume service acceptance test so that it works with the cf-deployment NFS service.
Please provide contextual information.
We want to validate the NFS service feature that is offered by cf-deployment:
https://github.com/cloudfoundry/cf-deployment/blob/main/operations/enable-nfs-volume-service.yml
The cf-deployment "fresh" environment will deploy the NFS broker and a test server:
cloudfoundry/cf-deployment#1204
Then we can activate the volume_service test on that environment:
https://github.com/cloudfoundry/relint-envs/pull/46
What version of cf-deployment have you run this cf-acceptance-test change against?
v43.3.0
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
It's not strictly a new test, we want to re-enable an existing test.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
150 seconds
What is the level of urgency for publishing this change?