chore: Combine go files generated from the grpc asset's protobuf definitions #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctlong
commented
Oct 24, 2023
Rather than manually maintaining a duplicate of the generated code under `helpers/assets/test`, we can just import the file directly now that there's a module and go modules will sort it out. This does still mean we have two of the same files, but at least we don't have to maintain the copy by copying and pasting. Now just using go modules commands can update to using the latest version.
ctlong
force-pushed
the
fix/combine-grpc-protos
branch
from
bd937d0
to
47d08bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
Yes
What is this change about?
Refactors CATs to not require manually copying and pasting the go files generated from the grpc asset's protobuf definitions whenever we regenerate them.
Also regenerates the go files.
Please provide contextual information.
None
What version of cf-deployment have you run this cf-acceptance-test change against?
None yet
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
None
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
None