Skip to content

Commit

Permalink
feat: Add ability for setting app_stats (#193)
Browse files Browse the repository at this point in the history
Context: cloudfoundry/uptimer#115

After adding this new measurement, our CI is failing this measurement
because the default value of 0 is too aggresssive for cf-deployment.
This PR adds the ablity to set app_stats when needed.
  • Loading branch information
winkingturtle-vmw committed May 9, 2024
1 parent 9e77ce9 commit 2ab9a59
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 0 deletions.
5 changes: 5 additions & 0 deletions bosh-deploy-with-created-release/task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ params:
# - This sets the maximum number of allowed uptimer failures for app pushability
# - The default threshold value of 0 is our working value for cf-deployment, and is likely to be updated

APP_STATS_THRESHOLD: 0
# - Optional
# - This sets the maximum number of allowed uptimer failures for app stats
# - The default threshold value of 0 is our working value for cf-deployment, and is likely to be updated

HTTP_AVAILABILITY_THRESHOLD: 0
# - Optional
# - This sets the maximum number of allowed uptimer failures for http availability
Expand Down
5 changes: 5 additions & 0 deletions bosh-deploy-with-updated-release-submodule/task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ params:
# - This sets the maximum number of allowed uptimer failures for app pushability
# - The default threshold value of 0 is our working value for cf-deployment, and is likely to be updated

APP_STATS_THRESHOLD: 0
# - Optional
# - This sets the maximum number of allowed uptimer failures for app stats
# - The default threshold value of 0 is our working value for cf-deployment, and is likely to be updated

HTTP_AVAILABILITY_THRESHOLD: 0
# - Optional
# - This sets the maximum number of allowed uptimer failures for http availability
Expand Down
5 changes: 5 additions & 0 deletions bosh-deploy/task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ params:
# - This sets the maximum number of allowed uptimer failures for app pushability
# - The default threshold value of 0 is our working value for cf-deployment, and is likely to be updated

APP_STATS_THRESHOLD: 0
# - Optional
# - This sets the maximum number of allowed uptimer failures for app stats
# - The default threshold value of 0 is our working value for cf-deployment, and is likely to be updated

HTTP_AVAILABILITY_THRESHOLD: 0
# - Optional
# - This sets the maximum number of allowed uptimer failures for http availability
Expand Down
2 changes: 2 additions & 0 deletions shared-functions
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ write_uptimer_deploy_config() {
--arg tcp_port ${tcp_port} \
--arg available_port ${available_port} \
--arg app_pushability ${APP_PUSHABILITY_THRESHOLD} \
--arg app_stats ${APP_STATS_THRESHOLD} \
--arg http_availability ${HTTP_AVAILABILITY_THRESHOLD} \
--arg tcp_availability ${TCP_AVAILABILITY_THRESHOLD} \
--arg recent_logs ${RECENT_LOGS_THRESHOLD} \
Expand All @@ -234,6 +235,7 @@ write_uptimer_deploy_config() {
},
"allowed_failures": {
"app_pushability": $app_pushability | tonumber,
"app_stats": $app_stats | tonumber,
"http_availability": $http_availability | tonumber,
"tcp_availability": $tcp_availability | tonumber,
"recent_logs": $recent_logs | tonumber,
Expand Down

0 comments on commit 2ab9a59

Please sign in to comment.