Change the test to polling instead of just a single sleep [main]

[joaopapereira]

Description of the Change

• Avoid flakyness due to time it takes to bind a service

[a-b]

Love this idea, let's see if this helps.

[weresch]

issue (blocking): I tried running this and found on occasion it failed, I think it's due to the order the apps can appear in the output. Sometimes APP2 comes first:

  OUT: Showing bound apps:
  OUT:    name                                        binding name                           status             message
  OUT:    APP2-1a263f4e-a731-4247-7fea-9dea533cdef0   ca204ee2-67cd-455e-68cf-afe0a557e805   create succeeded
  OUT:    APP1-cdd7753f-8c75-45e8-5cf7-37b5d063e594   e1c2f039-3950-48cf-613b-a09534ddf8d4   create succeeded

The test may need to be changed to validate that both appear but not rely on the order of them.

[weresch]

Suggested change

	ContainSubstring(`%s\s+%s\s+create succeeded\s*\n`, appName1, bindingName1),
	ContainSubstring(`%s\s+%s\s+create succeeded\s*\n`, appName2, bindingName2),
	))
	))
	sessionContents := string(session.Out.Contents())
	Expect(strings.Contains(sessionContents, fmt.Sprintf(`%s %s create succeeded`, appName1, bindingName1))).To(BeTrue())
	Expect(strings.Contains(sessionContents, fmt.Sprintf(`%s %s create succeeded`, appName2, bindingName2))).To(BeTrue())

[weresch]

I found the test can fail if app2 is listed first. If we get the session contents and search it for substrings the order doesn't matter.