cf revision command implementation [main] #3341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gururajsh
force-pushed
the
revision-test-main
branch
from
180f2c9 to
4057246
Compare
Co-authored-by: Lisa Burns <lisaburns@vmware.com> Signed-off-by: Steve Taylor <staylor@pivotal.io> Update help info related to revision command Return error when no app/revision is present
gururajsh
force-pushed
the
revision-test-main
branch
from
4057246 to
21c177c
Compare
|
|
||
| } | ||
|
|
||
| func revisionDeployed(revision resources.Revision, deployedRevisions []resources.Revision) bool { |
There was a problem hiding this comment.
Any reason for this function to be the only one that is not associated with the struct?
Comment on lines
+74
to
+77
| if len(labels) > 0 { | ||
| cmd.displayMetaData(labels) | ||
| cmd.UI.DisplayNewline() | ||
| } |
There was a problem hiding this comment.
Nit: Given that we are repeating this in different places I think that maybe the displayMetaData function should be the one that has this if statement and the Execute function would always call the function.
| app.GUID, | ||
| cmd.Version.Value, | ||
| ) | ||
| cmd.UI.DisplayWarnings(warnings) |
There was a problem hiding this comment.
Question: If we display the warnings in this line, are we not going to repeat them in lines 69 and 81 as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the revision command which the revision details of an app when given a revision version. The revision command is no longer experimental.