-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Prateek Gangwal to UAA and Credhub approver. #936
Merged
beyhan
merged 1 commit into
cloudfoundry:main
from
Identity-and-Credentials:pr/update-prateek-approver
Aug 2, 2024
Merged
Move Prateek Gangwal to UAA and Credhub approver. #936
beyhan
merged 1 commit into
cloudfoundry:main
from
Identity-and-Credentials:pr/update-prateek-approver
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credential Management (Credhub) and Identity and Auth (UAA) contributions Reviews: cloudfoundry/uaa#2980 cloudfoundry/uaa#2866 cloudfoundry/uaa#2937 cloudfoundry/credhub#751 Code Contributions: cloudfoundry/credhub#757 cloudfoundry/credhub#743 cloudfoundry/uaa-release#906 cloudfoundry/uaa#2915
Tallicia
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and will help the team's efficiency!
duanemay
approved these changes
Aug 1, 2024
jpalermo
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
beyhan
approved these changes
Aug 2, 2024
Congratulations @coolgang123! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credential Management (Credhub) and Identity and Auth (UAA) contributions
Reviews:
feat: Return a sorted IdP list- cloudfoundry/uaa#2980
fix: replace regex usage with simple search- cloudfoundry/uaa#2866
Fix documentation for OpenID connect clientJWT: cloudfoundry/uaa#2937
fix: api docs build failure: cloudfoundry/credhub#751
Code Contributions:
bump: Gradle version to the latest - cloudfoundry/credhub#757
Update kotlin to 2.0.0 - cloudfoundry/credhub#743
Enable configuring of cache for Identity providers in UAA - cloudfoundry/uaa-release#906
Identity provider key caching behavior causing lookup conflict- cloudfoundry/uaa#2915