Skip to content

Commit

Permalink
Auth provider server accepts unhandler requests
Browse files Browse the repository at this point in the history
We have observed the following flakes:

+-------+----------------------------------+-----------------------------------------------------
| Ended | Job                              | Url
+-------+----------------------------------+-----------------------------------------------------
| 2h    | main/run-tests-periodic          | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/13087
| 134d  | main/run-tests-periodic          | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/9873
| 275d  | main/run-tests-periodic          | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/6213
| 287d  | main/run-tests-periodic          | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/5890
| 317d  | main/run-tests-periodic          | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/5045
| 451d  | main/run-tests-periodic          | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/1404
| 490d  | main/run-tests-main              | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-main/builds/88
| 493d  | main/run-tests-periodic          | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/259

Something is trying to call /healthz on the oidc provider which fails
because unhandled requests are not allowed. We hope that by allowing
them (dafault response will be 500) we could find out more about what is
calling the endpoint.

Co-authored-by: Danail Branekov <danailster@gmail.com>
  • Loading branch information
georgethebeatle and danail-branekov committed Nov 1, 2023
1 parent 653bc6d commit dba5db9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion api/authorization/testhelpers/auth_provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func configureServer(server *ghttp.Server, signingKey *rsa.PrivateKey) {
applicationJSONHeader := http.Header{}
applicationJSONHeader.Add("Content-Type", "application/json")

server.SetAllowUnhandledRequests(false)
server.SetAllowUnhandledRequests(true)

server.RouteToHandler(
http.MethodGet,
Expand Down

0 comments on commit dba5db9

Please sign in to comment.