Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate org deletion timeout in smoke tests #3061

Closed
danail-branekov opened this issue Jan 15, 2024 · 0 comments
Closed

Investigate org deletion timeout in smoke tests #3061

danail-branekov opened this issue Jan 15, 2024 · 0 comments
Assignees
Labels

Comments

@danail-branekov
Copy link
Member

danail-branekov commented Jan 15, 2024

Smoke tests are occasionally failing in AfterSuite with org deletion timeout. Let's investigate what is causing this.

❯ flake-hunter "Org deletion timed out"
+-------+----------------------------------+-----------------------------------------------------
| Ended | Job                              | Url
+-------+----------------------------------+-----------------------------------------------------
| 1d    | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/13188
| 2d    | main/run-e2es-main               | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-main/builds/1030
| 7d    | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/13107
| 6d    | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/13119
| 7d    | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/13073
| 1d    | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/13185
| 1d    | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/13186
| 5d    | main/run-e2es-pr                 | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-pr/builds/2392
| 22d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/12811
| 29d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/12682
| 36d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/12556
| 51d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/12279
| 51d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/12276
| 50d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/12301
| 73d   | main/run-e2es-pr                 | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-pr/builds/2279
| 65d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/12006
| 72d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/11877
| 78d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/11773
| 65d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/12008
| 85d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/11638
| 92d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/11504
| 98d   | main/run-e2es-main               | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-main/builds/957
| 99d   | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/11365
| 110d  | main/run-e2es-main               | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-main/builds/948
| 110d  | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/11161
| 114d  | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/11074
| 114d  | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/11066
| 114d  | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/11065
| 139d  | main/run-e2es-pr                 | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-pr/builds/2095
| 141d  | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/10678
| 145d  | main/run-e2es-pr                 | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-pr/builds/2078
| 145d  | main/run-e2es-main               | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-main/builds/903
| 148d  | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/10544
| 157d  | main/run-e2es-pr                 | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-pr/builds/2007
| 176d  | main/run-e2es-eks-periodic       | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-eks-periodic/builds/2782
| 176d  | main/run-e2es-eks-periodic       | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-eks-periodic/builds/2752
| 178d  | main/run-e2es-eks-periodic       | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-eks-periodic/builds/2720
| 180d  | main/run-e2es-eks-periodic       | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-eks-periodic/builds/2702
| 182d  | main/run-e2es-pr                 | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-pr/builds/1907
| 182d  | main/run-e2es-pr                 | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-pr/builds/1906
| 182d  | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/9801
| 191d  | main/run-e2es-periodic           | https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/9551


@danail-branekov danail-branekov converted this from a draft issue Jan 15, 2024
georgethebeatle added a commit that referenced this issue Jan 15, 2024
…imeout

Print cforg namespace in fail handler
@georgethebeatle georgethebeatle moved this from 🔄 In progress to 🇪🇺 To do in Korifi - Backlog Jan 22, 2024
@georgethebeatle georgethebeatle moved this from 🇪🇺 To do to 🔄 In progress in Korifi - Backlog Mar 13, 2024
danail-branekov added a commit that referenced this issue Mar 19, 2024
Smoke tests have been failing frequently because org deletion times out.
Previous debug output showed that the timeout is caused by org namespace
being not deleted because of app pods do not disappear and remaining
pods are in phase `Pending` (e.g. see
https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/deploy-korifi-acceptance/builds/802)

We have found a [k8s bug
report](kubernetes/kubernetes#121435) that
pending pods cannot be deleted. We suspect that in those cases the
cluster is just being slow.

In order to workaround that bug, we simply ignore the org deletion exit
code as org deletion is not really in the focus of the smoke tests. Org
deletion is covered in details by e2e tests.

Also, delete the related debug logs as they are not needed anymore.

fixes #3061

Co-authored-by: Danail Branekov <danailster@gmail.com>
danail-branekov added a commit that referenced this issue Mar 19, 2024
Smoke tests have been failing frequently because org deletion times out.
Previous debug output showed that the timeout is caused by org namespace
being not deleted because of app pods do not disappear and remaining
pods are in phase `Pending` (e.g. see
https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/deploy-korifi-acceptance/builds/802)

We have found a [k8s bug
report](kubernetes/kubernetes#121435) that
pending pods cannot be deleted. We suspect that in those cases the
cluster is just being slow.

In order to workaround that bug, we simply ignore the org deletion exit
code as org deletion is not really in the focus of the smoke tests. Org
deletion is covered in details by e2e tests.

Also, delete the related debug logs as they are not needed anymore.

fixes #3061

Co-authored-by: Danail Branekov <danailster@gmail.com>
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
@github-project-automation github-project-automation bot moved this from 🔄 In progress to ✅ Done in Korifi - Backlog Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants