Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the 'statefulsetRunnerTemporarySetPodSeccompProfile' and 'jobTaskRunnerTemporarySetPodSeccompProfile' flags #3164

Closed
georgethebeatle opened this issue Mar 13, 2024 · 1 comment
Closed

Remove the 'statefulsetRunnerTemporarySetPodSeccompProfile' and 'jobTaskRunnerTemporarySetPodSeccompProfile' flags #3164

georgethebeatle opened this issue Mar 13, 2024 · 1 comment
Assignees
@danail-branekov @georgethebeatle
Labels
disruptive
Milestone
v0.13

Comments

@georgethebeatle
Copy link
Member

Background

We had a PR in Korifi that sets the default seccomp profile in the spec template of the korifi workloads (both statefulsets and jobs). This can be helpful when running software that requires additional privleges (such as istio). However this results in a change to the pod spec and restarts the respective pod which is disruptive to the users. That's why we added the flags mentioned in the title.

Action to take

Revert this commit and release it in a disruptive release (one that users will have to upgrade to in a maintainence window).
@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog Mar 13, 2024
georgethebeatle added a commit that referenced this issue Oct 16, 2024
@danail-branekov @georgethebeatle
Remove temporary helm values
6768bbc 
* `statefulsetRunnerTemporarySetPodSeccompProfile`
* `jobTaskRunnerTemporarySetPodSeccompProfile`

Those helm values were introduced to avoid workloads restart on Korifi
upgrade. With the upcoming release workloads would be restarted by an
unrelated change anyway, so it is a convenient moment to get rid of
those.

fixes #3164

Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
@danail-branekov danail-branekov mentioned this issue Oct 16, 2024
Merged
@danail-branekov danail-branekov added this to the v0.13 milestone Oct 16, 2024
@georgethebeatle
Copy link
Member Author

TODO: document the removal of the helm values in the release notes

georgethebeatle added a commit that referenced this issue Oct 16, 2024
@danail-branekov @georgethebeatle
Remove temporary helm values
0818a34 
* `statefulsetRunnerTemporarySetPodSeccompProfile`
* `jobTaskRunnerTemporarySetPodSeccompProfile`

Those helm values were introduced to avoid workloads restart on Korifi
upgrade. With the upcoming release workloads would be restarted by an
unrelated change anyway, so it is a convenient moment to get rid of
those.

issue #3164

Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov added a commit that referenced this issue Oct 17, 2024
@danail-branekov @georgethebeatle
Remove temporary helm values
82c2d66 
* `statefulsetRunnerTemporarySetPodSeccompProfile`
* `jobTaskRunnerTemporarySetPodSeccompProfile`

Those helm values were introduced to avoid workloads restart on Korifi
upgrade. With the upcoming release workloads would be restarted by an
unrelated change anyway, so it is a convenient moment to get rid of
those.

issue #3164

Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
@github-project-automation github-project-automation bot moved this from 🔄 In progress to ✅ Done in Korifi - Backlog Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danail-branekov danail-branekov

@georgethebeatle georgethebeatle

Labels
disruptive
Projects
Korifi - Backlog
Archived in project
Milestone
v0.13
Development

No branches or pull requests
2 participants
@danail-branekov @georgethebeatle