Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a Korifi API user I want to be able to get service broker fields when listing service instances #3289

Closed
danail-branekov opened this issue May 23, 2024 · 0 comments

Comments

@danail-branekov
Copy link
Member

GIVEN I have enabled the experimental managed services flag in the helm values
WHEN I have created service brokers
WHEN I /v3/service_instances?fields[service_plan.service_offering.service_broker]=guid,name
THEN I see the guids and names of the brokers providing the result service instances under included.service_brokers array, for example

{
  "included": {
    "service_brokers": [
      {
        "guid": "813e18bc-5c9e-4b27-990f-de2f398e9ba2",
        "name": "btp-sm"
      }
    ]
  },
  "pagination": {
  ...
  },
  "resources": [
    {
      "guid": "a07c8a84-1e85-4882-9764-fb85f57f46bd",
      "name": "my-service-instance",
      ...
  ]
}

Dev notes:

@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog May 23, 2024
@danail-branekov danail-branekov moved this from 🧊 Icebox to 🇪🇺 To do in Korifi - Backlog May 31, 2024
@danail-branekov danail-branekov self-assigned this Aug 27, 2024
danail-branekov added a commit that referenced this issue Aug 27, 2024
* Allow `managed` value for `CFServiceInstance.Type.Spec`
* Introduce the `PlanGUID` field on `CFServiceInstanceSpec`
* `ServiceInstanceRecord` implements the `relationships.Resource`
  interface. User provided services have no relationships, managed ones
  have a relationship to the service plan
* The relationships repository returns empty list for resources with no
  relationships.
* The broker fields are available in the `GET /v3/service_instances`
  response only if requested and the result service instances contain
  managed ones. Requesting those fields for user provided service
  instances only does not result into `include` field in the response

fixes #3289
@github-project-automation github-project-automation bot moved this from 🔄 In progress to ✅ Done in Korifi - Backlog Aug 29, 2024
@georgethebeatle georgethebeatle added this to the v0.13 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants