-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a Service Broker I want to get organization and space GUIDs when requested to provision a service #3439
Milestone
Comments
danail-branekov
changed the title
As a Service Broker I want to get organization and space id when requested to provision a service
As a Service Broker I want to get organization and space GUIDs when requested to provision a service
Aug 21, 2024
danail-branekov
added a commit
that referenced
this issue
Aug 27, 2024
georgethebeatle
pushed a commit
that referenced
this issue
Aug 29, 2024
github-project-automation
bot
moved this from 🔄 In progress
to ✅ Done
in Korifi - Backlog
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
GIVEN A service provisioning has been requested via
cf create-service
WHEN the provision request is sent to the OSBAPI service broker (via the
Provision
endpoint)THEN the service broker gets the organization and space GUIDs in the request payload
Dev notes
According to the
Provision
endpoint specification,organization_guid
andspace_guid
parameters are required. We did not implement them in our prototype and we saw no issues with the brokers we tested against. However, it is a good idea to implement the specification correctly.The OSBAPI provision request is performed by the controller which reconciles a managed
CFServiceInstance
. The controller could get the k8s namespace of theCFServiceInstace
and check itscloudfoundry.org/space-guid
label to figure out the space GUID. However, it is not easy to navigate to the CFOrg object as Korifi currently does not implement relationship from space to org.In order to make it easier, the
CFSpace
controller could label the namespace that backs theCFSpace
with thecloudfoundry.org/org-guid
label when reconciling theCFSpace
. Thus the managedCFServiceInstance
controller could just use theorg-guid
andspace-guid
labels on the namespace to provide them in the provision requestThe text was updated successfully, but these errors were encountered: