Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a Service Broker I want to get organization and space GUIDs when requested to provision a service #3439

Closed
danail-branekov opened this issue Aug 21, 2024 · 0 comments

Comments

@danail-branekov
Copy link
Member

danail-branekov commented Aug 21, 2024

GIVEN A service provisioning has been requested via cf create-service
WHEN the provision request is sent to the OSBAPI service broker (via the Provision endpoint)
THEN the service broker gets the organization and space GUIDs in the request payload

Dev notes

According to the Provision endpoint specification, organization_guid and space_guid parameters are required. We did not implement them in our prototype and we saw no issues with the brokers we tested against. However, it is a good idea to implement the specification correctly.

The OSBAPI provision request is performed by the controller which reconciles a managed CFServiceInstance. The controller could get the k8s namespace of the CFServiceInstace and check its cloudfoundry.org/space-guid label to figure out the space GUID. However, it is not easy to navigate to the CFOrg object as Korifi currently does not implement relationship from space to org.

In order to make it easier, the CFSpace controller could label the namespace that backs the CFSpace with the
cloudfoundry.org/org-guid label when reconciling the CFSpace. Thus the managed CFServiceInstance controller could just use the org-guid and space-guid labels on the namespace to provide them in the provision request

@danail-branekov danail-branekov converted this from a draft issue Aug 21, 2024
@danail-branekov danail-branekov changed the title As a Service Broker I want to get organization and space id when requested to provision a service As a Service Broker I want to get organization and space GUIDs when requested to provision a service Aug 21, 2024
danail-branekov added a commit that referenced this issue Sep 5, 2024
fixes #3288
fixes #3439

Co-authored-by: Yusmen Zabanov <yusmen.zabanov@sap.com>
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov added a commit that referenced this issue Sep 5, 2024
fixes #3288
fixes #3439

Co-authored-by: Yusmen Zabanov <yusmen.zabanov@sap.com>
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
Co-authored-by: Yusmen Zabanov <yusmen.zabanov@sap.com>
danail-branekov added a commit that referenced this issue Sep 9, 2024
fixes #3288
fixes #3439

Co-authored-by: Yusmen Zabanov <yusmen.zabanov@sap.com>
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov added a commit that referenced this issue Sep 9, 2024
fixes #3288
fixes #3439

Co-authored-by: Yusmen Zabanov <yusmen.zabanov@sap.com>
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov added a commit that referenced this issue Sep 9, 2024
fixes #3288
fixes #3439

Co-authored-by: Yusmen Zabanov <yusmen.zabanov@sap.com>
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov added a commit that referenced this issue Sep 9, 2024
fixes #3288
fixes #3439

Co-authored-by: Yusmen Zabanov <yusmen.zabanov@sap.com>
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
Co-authored-by: Yusmen Zabanov <yusmen.zabanov@sap.com>
@github-project-automation github-project-automation bot moved this from 🔄 In progress to ✅ Done in Korifi - Backlog Sep 9, 2024
@georgethebeatle georgethebeatle added this to the v0.13 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants