Configure eventually timeouts in e2e tests #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danail-branekov
previously approved these changes
Oct 12, 2023
georgethebeatle
force-pushed
the
configure-test-timeouts
branch
from
243b4c6 to
ad386f0
Compare
danail-branekov
previously approved these changes
Oct 13, 2023
danail-branekov
force-pushed
the
configure-test-timeouts
branch
2 times, most recently
from
9f24580 to
505c548
Compare
Instead of specifying cutom timeouts in `Eventually`, configure the default eventually timeout and polling interval consistently across e2e suites. Also, cf/kubectl utilities wait for the `gexec.Session` to exit so that tests can check the exit code directly without `Eventually` or explicit waits. Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov
force-pushed
the
configure-test-timeouts
branch
from
505c548 to
db33498
Compare
danail-branekov
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Instead of specifying cutom timeouts in
Eventually, configure thedefault eventually timeout and polling interval consistently across
e2e suites.
Tag your pair, your PM, and/or team
@danail-branekov