Add initial GET /v3/apps/:guid/processes/:type/stats endpoint #3307
Conversation
tests/e2e/apps_test.go
Outdated
|
|
||
| When("we wait for the metrics to be ready", func() { | ||
| BeforeEach(func() { | ||
| Eventually(func(g Gomega) { |
There was a problem hiding this comment.
I would recommend moving this Eventually into the JustBeforeEach above (line 255). Thus whenever stats are available we could check them with a single It. Besides being more "idiomatic", this would speed testing up as testing stats would push a single app (with two Its the test app is pushed twice)
There was a problem hiding this comment.
I tried to do that. Can you please check whether this is how you intended it to be used?
There was a problem hiding this comment.
Yes, this is what I meant. If you could just reorder BeforeEach and JustBeforeEach in the e2e test, I am going to merge it
|
Thanks for the PR, @gogolok It looks good, I have just put a small comment on the e2e test. |
gogolok
force-pushed
the
apps_process_stats
branch
from
3ae63ff to
ff5a43a
Compare
tests/e2e/apps_test.go
Outdated
| }).Should(Succeed()) | ||
| }) | ||
|
|
||
| BeforeEach(func() { |
There was a problem hiding this comment.
Final nitpick, could you move BeforeEach above JustBeforeEach? I find it more logical.
There was a problem hiding this comment.
I've changed the order
gogolok
force-pushed
the
apps_process_stats
branch
from
ff5a43a to
984fd07
Compare
|
@danail-branekov Do you have to retrigger something for https://github.com/cloudfoundry/korifi/actions/runs/9284917389/job/25548402806?pr=3307 ? |
|
Not sure why the job got cancelled, I had not noticed that. Retriggering it now |
Is there a related GitHub Issue?
#2340
What is this change about?
It adds the endpoint
GET /v3/apps/:guid/processes/:type/statsand returns the stats that are already available in the ProcessStats.Does this PR introduce a breaking change?
No
Acceptance Steps
cf push an app and try to access the stats endpoint.
It should deliver the same result as
cf curl /v3/processes/:guid/statsTag your pair, your PM, and/or team
None