Introduce experimental.managedServices.include helm value
#3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danail-branekov
force-pushed
the
issues/3262-experimental-managed-services-flag
branch
from
2210544 to
b625ea5
Compare
danail-branekov
force-pushed
the
issues/3262-experimental-managed-services-flag
branch
2 times, most recently
from
ca562d8 to
91ecdc6
Compare
danail-branekov
changed the title
experimentalManagedServicesEnabled helm valueexperimental.managedServices.include helm value
The upcoming managed services support would be initially disabled by setting the helm value to `false` (the default) Operators should deliberately enable the flag should they want to give the feature a try. This change simply introduces the flag in the helm chart, there is no implementation that uses it yet. The `deploy-on-kind` script sets it to `true` as it is meant to be run for development purposes. The kind installer sets it to `true` as well - whoever is installing Korifi on kind probably just wants to play with it, therefore enabling the experimental support does make sense. fixes #3262
danail-branekov
force-pushed
the
issues/3262-experimental-managed-services-flag
branch
from
91ecdc6 to
dd89962
Compare
tcdowney
approved these changes
Jun 10, 2024
| "type": "object" | ||
| } | ||
| }, | ||
| "description": "Experimental features. Make sure you do not enable those on production. No guarantee provided! Backwards incompatible changes in future are quite probable!", |
There was a problem hiding this comment.
Suggested change
| "description": "Experimental features. Make sure you do not enable those on production. No guarantee provided! Backwards incompatible changes in future are quite probable!", | |
| "description": "Experimental features. No guarantees are provided and breaking/backwards incompatible changes should be expected. These features are not recommended for use in production environments.", |
Suggesting a minor wording tweak. Otherwise it all LGTM. 👍
There was a problem hiding this comment.
Ugh, I have merged that without noticing your comment. I am goind to put that in the next PR
danail-branekov
deleted the
issues/3262-experimental-managed-services-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3262
What is this change about?
The upcoming managed services support would be initially disabled by
setting the helm value to
false(the default)Operators should deliberately enable the flag should they want to give
the feature a try.
This change simply introduces the flag in the helm chart, there is no
implementation that uses it yet. The
deploy-on-kindscript sets it totrueas it is meant to be run for development purposes.The kind installer sets it to
trueas well - whoever is installingKorifi on kind probably just wants to play with it, therefore enabling
the experimental support does make sense.
Does this PR introduce a breaking change?
No
Acceptance Steps
See story
Tag your pair, your PM, and/or team
@cloudfoundry/wg-cf-on-k8s