Include broker fields when listing managed service instances #3448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow `managed` value for `CFServiceInstance.Type.Spec` * Introduce the `PlanGUID` field on `CFServiceInstanceSpec` * `ServiceInstanceRecord` implements the `relationships.Resource` interface. User provided services have no relationships, managed ones have a relationship to the service plan * The relationships repository returns empty list for resources with no relationships. * The broker fields are available in the `GET /v3/service_instances` response only if requested and the result service instances contain managed ones. Requesting those fields for user provided service instances only does not result into `include` field in the response fixes #3289
georgethebeatle
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3289
What is this change about?
Include broker fields when listing managed service instances
managedvalue forCFServiceInstance.Type.SpecPlanGUIDfield onCFServiceInstanceSpecServiceInstanceRecordimplements therelationships.Resourceinterface. User provided services have no relationships, managed ones
have a relationship to the service plan
relationships.
GET /v3/service_instancesresponse only if requested and the result service instances contain
managed ones. Requesting those fields for user provided service
instances only does not result into
includefield in the responseTag your pair, your PM, and/or team
@georgethebeatle