Refactor binding controllers #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controllers/controllers/services/bindings/managed/controller.go
Outdated
Show resolved
Hide resolved
controllers/controllers/services/bindings/managed/controller.go
Outdated
Show resolved
Hide resolved
controllers/controllers/services/bindings/managed/controller.go
Outdated
Show resolved
Hide resolved
uzabanov
force-pushed
the
issues/3576-refactor-binding-controller
branch
2 times, most recently
from
97585e5 to
2f4e849
Compare
controllers/controllers/services/bindings/sbio/servicebinding.go
Outdated
Show resolved
Hide resolved
uzabanov
force-pushed
the
issues/3576-refactor-binding-controller
branch
2 times, most recently
from
5193b63 to
bdbf319
Compare
There was a problem hiding this comment.
There are a couple of tests that need backfilling. Also, one of the controllers tests is failing: https://github.com/cloudfoundry/korifi/actions/runs/12389316309/job/34582086211?pr=3654
controllers/controllers/services/bindings/sbio/servicebinding_test.go
Outdated
Show resolved
Hide resolved
uzabanov
force-pushed
the
issues/3576-refactor-binding-controller
branch
from
4ab11de to
8a9ddd5
Compare
uzabanov
force-pushed
the
issues/3576-refactor-binding-controller
branch
from
8a9ddd5 to
8790da7
Compare
The logic for servicebinding.io creation is moved to the respective controllers and some consants are moved to the korifiv1alpha1 package fixes cloudfoundry#3576 Co-authored-by: Danail Branekov <danailster@gmail.com>
uzabanov
force-pushed
the
issues/3576-refactor-binding-controller
branch
from
8790da7 to
8832e95
Compare
danail-branekov
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for servicebinding.io creation is moved to the respective controllers and some consants are moved to the korifiv1alpha1 package
Is there a related GitHub Issue?
#3576
Does this PR introduce a breaking change?
No