An app is staged when it has current droplet set #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It deletes the content of the `bin` directories on all levels Co-authored-by: Danail Branekov <danailster@gmail.com>
Checking for the ready condition on the app to determine whether the app is staged does not make sense as during an app restart, the app becomes unready (but remains staged as it references a valid droplet) Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
georgethebeatle
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
An app is staged when it has current droplet set
Checking for the ready condition on the app to determine whether the app
is staged does not make sense as during an app restart, the app becomes
unready (but remains staged as it references a valid droplet)
Does this PR introduce a breaking change?
No
Tag your pair, your PM, and/or team
@georgethebeatle