Create a uniques app whenenver we bind/unbind to a service instance #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change all tests that were binding to as service instances were using the buildpack app. When we bind to an app that is ready and running the app becomes unready for a while and restarts. If we try to run a task against such an app the operation will fail, because the app is unready. This change creates a cheap app record and binds/unbinds to this app to prevent messing with the running app state Co-authored-by: Yusmen Zabanov <yusmen.zabanov@sap.com>
danail-branekov
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Before this change all tests that were binding to as service instances
were using the buildpack app. When we bind to an app that is ready and
running the app becomes unready for a while and restarts. If we try to
run a task against such an app the operation will fail, because the app
is unready. This change creates a cheap app record and binds/unbinds to
this app to prevent messing with the running app state