Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(relint-base): Use only necessary, latest packages in image #271

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Oct 5, 2023

No description provided.

@ctlong ctlong requested a review from a team October 5, 2023 23:34
@ctlong ctlong force-pushed the fix/relint-base/use-latest-packages branch from 66c189a to 4305744 Compare October 5, 2023 23:38
@ctlong ctlong changed the title Fix(relint-base): Use latest packages in image Fix(relint-base): Use only necessary, latest packages in image Oct 5, 2023
davewalter
davewalter previously approved these changes Oct 5, 2023
Some, like yq, appear to be unused. While some, like wget, are already
installed.
Seems nice to use `set` to get error checking and push up failures,
which then also allows us to use semicolons instead of double ampersands
to break lines.
@ctlong ctlong force-pushed the fix/relint-base/use-latest-packages branch from 7621a0c to a583c10 Compare October 5, 2023 23:57
@ctlong ctlong requested review from davewalter and a team October 5, 2023 23:57
Copy link
Member

@davewalter davewalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume we don't use yq anywhere any more.

@ctlong
Copy link
Member Author

ctlong commented Oct 6, 2023

Looks good. I assume we don't use yq anywhere any more.

I couldn't find any instances of using yq with this image from a quick search. If a failure occurs then I'll add it back :)

@ctlong ctlong merged commit 285ec24 into main Oct 6, 2023
11 checks passed
@ctlong ctlong deleted the fix/relint-base/use-latest-packages branch October 6, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants